Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate chopsticks #9965

Merged
merged 30 commits into from
Feb 27, 2024
Merged

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Oct 20, 2023

related: #9903

  • added 'Fork Locally' button, when click, it will switch to ChopsticksProvider as the provider for api

@qiweiii qiweiii marked this pull request as ready for review October 24, 2023 02:42
@qiweiii
Copy link
Contributor Author

qiweiii commented Oct 24, 2023

@jacogr would you like to have a review

@ermalkaleci
Copy link

Just quick overview on how this works. The moment you create a ChopsticksProvider, you are creating a chopsticks instance running locally on browser and everything related to runtime WASM is executed on web worker to prevent blocking UI thread. ChopsticksProvider will behave as rpc and handle subscription and query the local chain.

@xlc
Copy link
Contributor

xlc commented Oct 31, 2023

@jacogr this is ready

@xlc
Copy link
Contributor

xlc commented Nov 24, 2023

@jacogr ptal

@xlc
Copy link
Contributor

xlc commented Nov 28, 2023

I really really really don't want to deploy a fork UI just to get this out.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good. Merge conflicts just need to be fixed. After I will run the branch as a sanity check 👍

@qiweiii
Copy link
Contributor Author

qiweiii commented Feb 18, 2024

@TarikGul Fixed, please have a try

@TarikGul
Copy link
Member

@qiweiii I'll have this reviewed today or tomorrow, seems as if there is still a merge conflict.

@qiweiii
Copy link
Contributor Author

qiweiii commented Feb 26, 2024

@qiweiii I'll have this reviewed today or tomorrow, seems as if there is still a merge conflict.

yes, almost everyday there are updates to package.json on master branch by CI, so that creates the conflict

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks really great. Just some small changes, and I think were good to go. I tried out your branch. It was really awesome using chopsticks so easily, Nice Job 🚀 .

@qiweiii
Copy link
Contributor Author

qiweiii commented Feb 27, 2024

All fixed @TarikGul

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@TarikGul TarikGul merged commit 8208fc5 into polkadot-js:master Feb 27, 2024
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants