-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate chopsticks #9965
Integrate chopsticks #9965
Conversation
@jacogr would you like to have a review |
Just quick overview on how this works. The moment you create a ChopsticksProvider, you are creating a chopsticks instance running locally on browser and everything related to runtime WASM is executed on web worker to prevent blocking UI thread. ChopsticksProvider will behave as rpc and handle subscription and query the local chain. |
@jacogr this is ready |
@jacogr ptal |
I really really really don't want to deploy a fork UI just to get this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good. Merge conflicts just need to be fixed. After I will run the branch as a sanity check 👍
@TarikGul Fixed, please have a try |
@qiweiii I'll have this reviewed today or tomorrow, seems as if there is still a merge conflict. |
yes, almost everyday there are updates to package.json on master branch by CI, so that creates the conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks really great. Just some small changes, and I think were good to go. I tried out your branch. It was really awesome using chopsticks so easily, Nice Job 🚀 .
All fixed @TarikGul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
related: #9903
ChopsticksProvider
as the provider for api